Connection close - #6
Merged
Merged
Conversation
Adds a host-agnostic interface that generated JNI bind/unbind code can use to coordinate ServiceConnection cleanup with the host application's teardown lifecycle. * IBindingLifecycleCoordinator: register/unregister Runnable cleanups * BindingLifecycleRegistry: volatile holder for the host's coordinator; generated code is a no-op when no coordinator is installed
Eabramov84
force-pushed
the
connection_close
branch
from
May 15, 2026 18:08
b0ea728 to
04d692e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Adds a host-agnostic Service Provider Interface (SPI_ that generated JNI bind/unbind code can use to coordinate serviceConnection cleanup with the host application's teardown lifecycle. The need arises when a JNI client binds a Service via a Context whose lifetime is shorter than the binding (e.g. an Android Service Context hosting the engine) -- the host has to drive unbind before that Context is destroyed or Android logs ServiceConnectionLeaked
✅ Checks
ℹ Additional Information